Update PUBLISH.md documentation #1146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamalwaysuncomfortable
requested changes
Jan 13, 2026
Member
iamalwaysuncomfortable
left a comment
iamalwaysuncomfortable
left a comment
There was a problem hiding this comment.
A few small changes and then it's good.
PUBLISH.md
Outdated
Comment on lines
20
to
21
| mv latest_release/wasm/dist/${PREVIOUS_RELEASE} wasm/dist/${PREVIOUS_RELEASE} | ||
| mv latest_release/sdk/dist/${PREVIOUS_RELEASE} sdk/dist/${PREVIOUS_RELEASE} |
There was a problem hiding this comment.
Suggested change
| mv latest_release/wasm/dist/${PREVIOUS_RELEASE} wasm/dist/${PREVIOUS_RELEASE} | |
| mv latest_release/sdk/dist/${PREVIOUS_RELEASE} sdk/dist/${PREVIOUS_RELEASE} |
There was a problem hiding this comment.
This doesn't need to exist as the build command overwrites the latest release and the deploy command explicity cd's into the dir and releases it.
Collaborator
Author
There was a problem hiding this comment.
You mentioned that a release packages both the testnet and mainnet binaries.
Say we're releasing an update to testnet, my understanding was that we could:
- build testnet
- don't have to rebuild mainnet, we can just re-use the latest mainnet release binaries. This is what I'm trying to specify with this line.
Let me know if this is wrong or you prefer we document that one should always build both branches
Comment on lines
+26
to
+21
| git tag ${SDK_TAG} | ||
| git push origin ${SDK_TAG} |
There was a problem hiding this comment.
Suggested change
| git tag ${SDK_TAG} | |
| git push origin ${SDK_TAG} | |
| git tag -a ${SDK_TAG} | |
| git push origin ${SDK_TAG} | |
| ## If gh cli is installed, otherwise, create the release manually. | |
| gh release create ${SDK_TAG} --notes-from-tag |
vicsn
force-pushed
the
release-documentation
branch
from
8735c72 to
4ae9efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Updates the release documentation based on our recent conversation. It is hella ugly and likely incomplete, but keen to get the specification correct before we start proposing any automation.
Also closes #1145