Label tmux windows in devnet as validators or clients #3619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
reviewed
Apr 30, 2025
A previous commit had the `--offline` and `--debug` flags added to devnet.sh by accident.
niklaslong
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR labels the tmux windows spawned by
devnet.shmore clearly. Each validator spawns in a window labeledvalidator-i(where i is its index) and each client in a window labeledclient-i.The change makes it a little easier to figure out which windows run validators, not clients. The labels are also identical to the files in which each node's log is stored.
Finally, the PR also makes log verbosity a constant, so you can change it (albeit only by modifying the file) to increase log output when you are debugging.
Test Plan
devnet.shis only used for local development and not in production. CI also has its own devnet script at.circle/devnet_ci.sh.So, I ran the script locally and verified it works as expected, which should be sufficient for a change like this.