Rename test_network flag to devnet#4265
Draft
kaimast wants to merge 3 commits into
Draft
Conversation
kaimast
commented
May 13, 2026
| echo "Running shellcheck..." | ||
| shellcheck -x .ci/*.sh scripts/*.sh | ||
| else | ||
| echo "warning: shellcheck not installed, skipping script lint (CI will still run it)" |
Contributor
Author
There was a problem hiding this comment.
I added this, so setups where shellcheck is not installed or not available do not break
kaimast
commented
May 13, 2026
| update Update snarkOS | ||
| ``` | ||
|
|
||
| The following are the options for the `snarkos start` command: |
Contributor
Author
There was a problem hiding this comment.
I made this argument list collapsible because it is massive
kaimast
force-pushed
the
refactor/devnet-flag
branch
from
48f1122 to
3170b0b
Compare
kaimast
force-pushed
the
refactor/devnet-flag
branch
from
3170b0b to
a283a21
Compare
Collaborator
|
This will require leo, snarkos-stress-testing, SDK integration tests, and potentially other unknown integration testing dependents to update. I'd advocate against this change |
Contributor
Author
It should not break anything as the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR also enables lints for all files in
./scriptsand fixes any remaining warnings with the devnet scripts.