Unify reported snarkOS versions through .cargo/release-version#4287
Draft
Copilot wants to merge 2 commits into
Draft
Unify reported snarkOS versions through .cargo/release-version#4287Copilot wants to merge 2 commits into
.cargo/release-version#4287Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix multiple registrations of package versions
Unify reported snarkOS versions through May 29, 2026
.cargo/release-version
vicsn
requested changes
Jun 4, 2026
|
|
||
| fn main() { | ||
| version_env::emit_version_env(); | ||
| built::write_built_file().expect("Failed to acquire build-time information"); |
Collaborator
There was a problem hiding this comment.
@copilot do we still need this or can we throw it?
Contributor
Author
There was a problem hiding this comment.
We still need built::write_built_file() here. node/rest/src/version.rs still reads the generated built_info::GIT_COMMIT_HASH and built_info::GIT_HEAD_REF, so dropping it would break that module.
|
|
||
| fn main() { | ||
| version_env::emit_version_env(); | ||
| built::write_built_file().expect("Failed to acquire build-time information"); |
Collaborator
There was a problem hiding this comment.
@copilot do we still need this or can we throw it?
Contributor
Author
There was a problem hiding this comment.
We still need built::write_built_file() here. node/metrics/src/lib.rs still uses the generated built_info::GIT_COMMIT_HASH, built_info::GIT_HEAD_REF, and built_info::FEATURES_LOWERCASE_STR, so this build step can't be removed yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported versions were coming from multiple crate-local sources (
CARGO_PKG_VERSION/PKG_VERSION), which required updating the same release number in several places. This change makes the user-facing/runtime-reported version come from a single root source:.cargo/release-version.Centralize the reported version
.cargo/release-versionv4.6.0→4.6.0)SNARKOS_VERSIONSwitch version consumers to the shared source
SNARKOS_VERSIONinstead of crate-localCARGO_PKG_VERSIONbuilt_info::PKG_VERSIONAlign CLI version output
snarkos --versionnow includes the unified release version alongside git branch/commit and enabled featuresAdd a focused guardrail
SNARKOS_VERSIONmatches.cargo/release-versionThis keeps reported versions tied to one root file without changing the existing package/dependency version structure used by the workspace.