Skip to content

Add CI log-size regression checks with verbosity 4 and per-test/node thresholds#4305

Draft
Copilot wants to merge 2 commits into
stagingfrom
copilot/add-tests-log-size-regressions
Draft

Add CI log-size regression checks with verbosity 4 and per-test/node thresholds#4305
Copilot wants to merge 2 commits into
stagingfrom
copilot/add-tests-log-size-regressions

Conversation

Copilot AI commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

This updates .ci network test scripts to actively catch logfile growth regressions. Tests now run at --verbosity 4 and enforce configurable logfile size caps per test and node type.

  • Shared log validation (.ci/utils.sh)

    • Extended check_logs with optional size-limit parameters:
      • max_validator_log_size_bytes
      • max_client_log_size_bytes
    • Added hard-fail checks when a node logfile exceeds its configured bound.
    • Corrected the validator iteration condition in check_logs so validator logs are actually checked.
  • Per-test size bounds + verbosity 4

    • Updated scripts to run nodes with verbosity 4 and pass explicit size bounds into check_logs:
      • .ci/test_devnet.sh (validator + client bounds)
      • .ci/test_full_upgrade.sh (validator + client bounds)
      • .ci/test_partial_upgrade.sh (validator bound)
      • .ci/test_db_backup.sh (validator bound)
      • .ci/test_reset_minority.sh (validator bound)
      • .ci/test_restart_majority.sh (validator bound)
  • Usage pattern

    check_logs "$log_dir" "$total_validators" "$total_clients" "$max_warnings" \
      "$MAX_VALIDATOR_LOG_SIZE_BYTES" "$MAX_CLIENT_LOG_SIZE_BYTES"

Copilot AI linked an issue Jun 4, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Add tests to assert log file size limits Add CI log-size regression checks with verbosity 4 and per-test/node thresholds Jun 4, 2026
Copilot finished work on behalf of vicsn June 4, 2026 20:26
Copilot AI requested a review from vicsn June 4, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Test against log size regressions

2 participants