misc by tfredh · Pull Request #105 · PuMProfessionals/pump-web-v2

tfredh · 2022-10-09T20:46:20Z

just trying to get familiar.

Changes:

used object when mapping navbar links
edited blog filter endpoint to avoid blogs being filtered through more than once

Idk, random stuff. Could be bad changes

made iframe onLoad a js function
spaces to help me separate site portions in my head
moved conditional check for Icon to decrease lines
give posts (in cache/cache.js) an id to avoid react key prop error

xsharonhe

good changes overall! small comments - will approve just prefer to have some of the questions answered first before approving. also in the future, could we have the PR title be more descriptive? eg. cleanup / refactor of website (misc is kinda vague)

will check locally afterwards

xsharonhe · 2022-10-11T01:58:42Z

utils/helpers.js

@@ -0,0 +1,10 @@
+// export function capitalizeWords(str) {


is this needed for anything?

oh nope. I thought I could use it and then realized it wouldn't work. I left it in case I thought of a way to use it later

sections/home/TopSection.jsx

xsharonhe · 2022-10-11T02:00:13Z

sections/Navbar.jsx

+  Home: "",
+  "About Us": "about",
+  Resources: "resources",
+  Events: "events",
+  Community: "community",


nit: almost prefer for consistency that the keys all be strings - would this affect anything?

do you think there is a way to use RESOURCES as the key names here? seems redundant to have both

sections/Navbar.jsx

xsharonhe · 2022-10-11T02:00:46Z

sections/Navbar.jsx


 {
-  /* TODO: Refactor into object? paths must be same as linked pages*/
+  /* @TODO: Refactor into object? paths must be same as linked pages */


i think we can remove the redo comment here yes

xsharonhe · 2022-10-11T02:01:56Z

sections/Navbar.jsx

+          {RESOURCES.map((resource) => (
            <Resource key={resource}>
-              <Link href={`/${PATHS[index]}`}>
+              <Link href={`/${PATH_NAMES[resource]}`}>


I would pull this out into a variable so it isn't stated twice for repetition now that I think about it

xsharonhe · 2022-10-11T02:02:10Z

pages/resources/blog.jsx

  }, []);

  const handleChange = (searchValue, tagValues, releaseValues) => {
+    // console.log([searchValue, tagValues, releaseValues]);


we can remove this altogether

xsharonhe · 2022-10-11T02:02:58Z

pages/api/blog.js

    - tags = tags to filter
 */
 export default async (req, res) => {
+  // console.log("tt", req.query);


same here please remove console statements altogether

xsharonhe · 2022-10-11T02:04:06Z

lib/cache.js

-  export const authors = ${getAuthors()};
-  export const opportunities = ${getOpportunities()};
+const postsWithoutId = ${getProjects()};
+export const posts = postsWithoutId.map(post => {


Math.random() would assign a random id to this right? could we also add maybe something that would tell us what post it is like project name or something so? not too sure if it matters but might be more descriptive than a random number

tfredh · 2022-10-12T01:11:01Z

good changes overall! small comments - will approve just prefer to have some of the questions answered first before approving. also in the future, could we have the PR title be more descriptive? eg. cleanup / refactor of website (misc is kinda vague)

will check locally afterwards

Ah, alright. I'll also try and make fixes and commit again before that

xsharonhe · 2022-10-13T00:42:11Z

pages/resources/blog/[slug].jsx

  try {
-    postPaths = await prisma.post.findMany();
+    // @P_ERR
+    // postPaths = await prisma.post.findMany();


what is the specific error here? this is not using our database but relying on our cache so just want to be sure i forgot to add this in earlier

im sure its because i keep updating things like vulnerabilities but just curious if you could screenshot or smth

Yep, here's my browser's screen,
https://gyazo.com/dd31a8773c9c771cf60c427477847645

This is the terminal's,
https://gyazo.com/b9591bcecad01bf3239332ca6bce2fb3
https://gyazo.com/668c1b53fadd231d0583e32020b9c1f1

oh this is because you don't have the .env file - I have some time to dig it up tmrw

tfredh added 2 commits October 9, 2022 16:34

misc

4511b00

n

3c207ef

tfredh force-pushed the random-qol branch from 580c460 to 3c207ef Compare October 9, 2022 21:27

tfredh added 3 commits October 9, 2022 17:35

freeze immutable arr

0b0bfa0

wwwwwwwwwwwwwwwwwwwwwwww

63c66e8

give posts id for react child

7da2db9

tfredh requested a review from xsharonhe October 10, 2022 18:45

xsharonhe reviewed Oct 11, 2022

View reviewed changes

tfredh added 2 commits October 11, 2022 21:16

pr fixes and notes

53754da

pr fixes and notes

ae8db27

xsharonhe reviewed Oct 13, 2022

View reviewed changes

Conversation

tfredh commented Oct 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xsharonhe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tfredh commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tfredh commented Oct 9, 2022 •

edited

Loading

tfredh commented Oct 12, 2022 •

edited

Loading