Dev/metadata#26
Merged
Merged
Conversation
Moohan
requested changes
Sep 2, 2025
Moohan
left a comment
Moohan
left a comment
Member
There was a problem hiding this comment.
Works well for me.
Most suggestions are around the messages and warnings in the console.
The progress message was being printed to the console as `0s` or `1s`, not required and potentially confusing. CSV lazy reading is fine if the user is on UNIX (linux/mac), it's only not good when on Windows, so limit it to that. This should make reading CSV files (metadata + some of the older lookups) faster on Posit Workbench.
This offloads metadata loading to the first call of `metadata()`. When the lookup is loaded, it sets some attributes, such as where the metadata file is and whether it exists, but it's not loaded initially. Overall, I think this is a better approach. The only downside is I couldn't figure out a good way to partially print the top few rows of the metadata, as that (obviously) involves reading it.
…load Refactor to make loading the metadata be on demand
Updated parameter documentation for clarity.
bnowok
approved these changes
May 6, 2026
bnowok
left a comment
bnowok
left a comment
Contributor
There was a problem hiding this comment.
I've made some changes to the wording only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added metadata functionality to
get_spd().