Add a new function for reading the 'National Reference Files'#56
Open
Moohan wants to merge 5 commits into
Open
Add a new function for reading the 'National Reference Files'#56Moohan wants to merge 5 commits into
Moohan wants to merge 5 commits into
Conversation
This allows reading any file in the top-level directory `<lookups>/Unicode/National Reference Files/` by name. The filename search is case-insensitive and will drop the extension (if provided). If there are multiple file types available, it will choose parquet preferentially. This preference code was already in `find_specific_file`, so I refactored it out of there so I could reuse it for this new function.
If a given filename isn't matched and the user has `{stringdist}` installed, it will try to suggest close matches in the error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows reading any file in the top-level directory
<lookups>/Unicode/National Reference Files/by name. The filename search is case-insensitive and will drop the extension (if provided). If there are multiple file types available, it will choose parquet preferentially. This preference code was already infind_specific_file, so I refactored it out of there so I could reuse it for this new function.If a given filename isn't matched and the user has
{stringdist}installed, it will try to suggest close matches in the error message.