BYOC_ID: 45127 Refactor - GP ooh diagnosis#1267
Open
Jennit07 wants to merge 16 commits into
Open
Conversation
lizihao-anu
changed the title
LucyEmma22
reviewed
Mar 23, 2026
LucyEmma22
reviewed
Mar 23, 2026
LucyEmma22
reviewed
Mar 23, 2026
LucyEmma22
reviewed
Mar 23, 2026
LucyEmma22
reviewed
Mar 23, 2026
LucyEmma22
reviewed
Mar 23, 2026
LucyEmma22
reviewed
Mar 23, 2026
LucyEmma22
reviewed
Mar 23, 2026
LucyEmma22
reviewed
Mar 23, 2026
| ) %>% | ||
| # Filter to match BOXI extraction | ||
| dplyr::filter( | ||
| sc_start_financial_year == c_year, # TO-DO: filtered variables are not currently in the denodo view. |
Collaborator
There was a problem hiding this comment.
The Denodo table has a column called financial_year (integer64)?
Collaborator
|
TO-DO: Add extra parameters to |
LucyEmma22
reviewed
Mar 24, 2026
LucyEmma22
reviewed
Mar 24, 2026
LucyEmma22
reviewed
Mar 24, 2026
LucyEmma22
reviewed
Mar 24, 2026
Collaborator
Author
|
HI @lizihao-anu This PR is ready for review again - comment here: #1268 (comment) also applies |
Jennit07
added
On hold
Collaborator
Author
|
Dependency missing: Readcode file |
This was referenced Apr 13, 2026
|
This Pull Request is stale because it has been at least 30 days with no activity. It will be closed if there is no activity within 7 days. |
Collaborator
|
Waiting on dependency: readcode file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring of:
Note: there are some TO-DO actions on this PR due to the renaming of variables or variables that do not exist. This was picked up by UAT and will be actioned by NSS. Placeholders have been added in place for now.