BYOC_ID: 45366 - Refactor ooh consultations#1280
Conversation
|
Update: PR ready for review |
|
|
||
| # Disconnect from Denodo | ||
| on.exit(try(DBI::dbDisconnect(denodo_connect), silent = TRUE), add = TRUE) | ||
|
|
There was a problem hiding this comment.
This line is above where the data is read in other refactored scripts (i.e. above line 22 here). I'm not sure if this makes a difference but might be nice to move it for consistency?
| year, | ||
| file_path = get_boxi_extract_path(year = year, type = "gp_ooh-c") | ||
| denodo_connect = get_denodo_connection(BYOC_MODE = BYOC_MODE), | ||
| file_path = get_boxi_extract_path(year = year, type = "gp_ooh-c"), |
There was a problem hiding this comment.
I think get_boxi_extract_path should have BYOC_MODE passed to it:
file_path = get_boxi_extract_path(year = year, type = "gp_ooh-c", BYOC_MODE),
| gender = "gender", | ||
| postcode = "patient_postcode", | ||
| hbrescode = "patient_nhs_board_code_9_curr", | ||
| hscp = "hscp_of_residence_code_curr", |
There was a problem hiding this comment.
Waiting for this to be changed from hcsp_of_residence_code_curr following UAT feedback.
| location = "treatement_location_code", | ||
| location_description = "treatment_location_description", | ||
| hbtreatcode = "treatment_nhs_board_code_9", | ||
| kis_accessed = "kis_accessed", |
There was a problem hiding this comment.
This is a factor in BOXI and character in Denodo. I'm not sure if that will have any downstream effects?
Does |
Jennit07
added
ready for PHS testing
PR complete
Preprod data available
On hold
|
This Pull Request is stale because it has been at least 30 days with no activity. It will be closed if there is no activity within 7 days. |
|
Waiting on UAT changes |
3 participants
refactoring of targets missing from here as this should be done in the top level script