BYOC_ID: 40072 refactor-acute

[OluwatobiOni]

No description provided.

[OluwatobiOni]

Dependency missing: Acute CUP file

[Jennit07]

I'm getting the following error on this line:

Error in `dplyr::mutate()`:
ℹ In argument: `month_name = month_order[.data$costmonthnum]`.
Caused by error:
! `month_name` must be size 100 or 1, not 0.
Run `rlang::last_trace()` to see where the error occurred.
Called from: signal_abort(cnd, .file)

We think this is due to costmonthnum being an integer64 variable but UAT tests show this should be numeric. This has been flagged and should be updated in the next round of UAT feedback

[lizihao-anu]

I think it happened in refactoring some dataset before. I will have a look at get back to suggest changes to make it consistent.

[Jennit07]

I have reviewed this PR and it looks good! there is an error i am getting which i have commented above. This should be corrected in the next round of UAT feedback.

Waiting on:

• Acute CUP file
• data types updated in UAT

This will be ready for BYOC testing once the two issues are addressed.

[OluwatobiOni]

acute cup file has now been made available but some UAT to-dos before this PR is ready for testing:

IN THE ACUTE FILE:

• The UAT data type changes earlier requested is yet to be updated by NSS
• nhs_board_of_residence_code_curr to be changed to nhs_hb_of_residence_code_curr
• "include_gls_record" field to be removed in sdl

IN THE ACUTE CUP FILE:

• cup_marker is currently integer64. Should be cast as integer
• acute_admission_financial_year is currently integer64. Should be cast as integer
• acute_discharge_financial_year is currently integer64. Should be cast as integer