Skip to content

BYOC_ID: 46080 Refactor SC Client#1314

Open
LucyEmma22 wants to merge 13 commits into
developmentfrom
refactor-sc-client
Open

BYOC_ID: 46080 Refactor SC Client#1314
LucyEmma22 wants to merge 13 commits into
developmentfrom
refactor-sc-client

Conversation

@LucyEmma22

@LucyEmma22 LucyEmma22 commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

LucyEmma22
LucyEmma22 commented Apr 29, 2026
View reviewed changes
Comment thread R/read_lookup_sc_client.R
} else {
client_data <- client_data
}

@LucyEmma22 LucyEmma22 Apr 29, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed intermediate saving. See comment in #1313

@LucyEmma22

LucyEmma22 commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Notes:

  • Data not yet available
  • Check SDL table names
  • Check that there are still 2 separate tables in the SDL view (one by year and one by quarter)
  • Check get_sc_client_lookup_path() in get_sc_lookup_paths.R
  • Dependency: sc_demog_lookup (output by process_lookup_sc_demographics())

@LucyEmma22 LucyEmma22 added On hold Waiting for something / someone outside of our control BYOC dependency missing PR ready for review labels Apr 30, 2026
@LucyEmma22 LucyEmma22 requested a review from OluwatobiOni May 6, 2026 08:47
@Jennit07

Jennit07 commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Notes:

  • Data not yet available
  • Check SDL table names
  • Check that there are still 2 separate tables in the SDL view (one by year and one by quarter)
  • Refactor get_sc_client_lookup_path() in get_sc_lookup_paths.R
  • Dependency: sc_demog_lookup (output by process_lookup_sc_demographics())

Notes:

  • Data not yet available
  • Check SDL table names
  • Check that there are still 2 separate tables in the SDL view (one by year and one by quarter)
  • Refactor get_sc_client_lookup_path() in get_sc_lookup_paths.R
  • Dependency: sc_demog_lookup (output by process_lookup_sc_demographics())

for get_sc_client_lookup_path please see #1313 for how i refactored get_sc_demog_lookup_path() as this might work similar

Jennit07
Jennit07 reviewed May 11, 2026
View reviewed changes
Comment thread R/get_sc_lookup_paths.R Outdated
LucyEmma22 and others added 3 commits May 11, 2026 10:23
@OluwatobiOni

OluwatobiOni commented May 18, 2026

Copy link
Copy Markdown
Collaborator

PR code looks good. Awaiting data for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jennit07 Jennit07 Jennit07 left review comments

@OluwatobiOni OluwatobiOni Awaiting requested review from OluwatobiOni

At least 1 approving review is required to merge this pull request.

Assignees

@OluwatobiOni OluwatobiOni

Labels

BYOC dependency missing On hold Waiting for something / someone outside of our control PR complete Preprod data not available

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LucyEmma22 @Jennit07 @OluwatobiOni @AghimienI