BYOC_ID: 46036 - Refactor NSU#1316
Open
lizihao-anu wants to merge 3 commits into
Open
Conversation
lizihao-anu
added
On hold
Jennit07
reviewed
May 13, 2026
| ) %>% | ||
| dplyr::collect() | ||
| } else { | ||
| nsu_data <- read_file(get_nsu_path(year)) |
Collaborator
There was a problem hiding this comment.
i think the get_nsu_path(year) will need refactored to include byoc for running locally
Jennit07
reviewed
May 13, 2026
| c_year <- convert_fyyear_to_year(year) | ||
|
|
||
| if (isTRUE(BYOC_MODE)) { | ||
| denodo_connect <- get_denodo_connection(BYOC_MODE = BYOC_MODE) |
Collaborator
There was a problem hiding this comment.
wondering if we need to add this as an argument on the function to follow the same format as other functions
Collaborator
|
Just a few comments but this is ready for testing when we have the data available. |
Jennit07
reviewed
Jun 8, 2026
| denodo_connect, | ||
| dbplyr::in_schema("sdl", "sdl_nsu_source") # TODO: finalise this sdl view | ||
| ) %>% | ||
| dplyr::filter(costs_financial_year == c_year) %>% |
Collaborator
There was a problem hiding this comment.
TODO: check the name of the variable in the SDL view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review