BYOC_ID: 45936 - Refactor sc care homes#1318
Draft
Jennit07 wants to merge 73 commits into
Draft
Conversation
Jennit07
added
PR complete
Preprod data not available
PR ready for review
BYOC
and removed
PR ready for review
ready for PHS testing
PR complete
labels
lizihao-anu
changed the title
Merge branch 'refactor-sc-demog' into refactor-sc-care-homes # Conflicts: # DESCRIPTION # _targets.R # man/get_byoc_intermediate_path.Rd # man/get_byoc_output_files.Rd # man/get_dd_path.Rd # man/get_demographic_cohorts_path.Rd # man/get_file_path.Rd # man/get_homelessness_completeness_path.Rd # man/get_ltcs_path.Rd # man/get_nsu_path.Rd # man/get_practice_details_path.Rd # man/get_readcode_lookup_path.Rd # man/get_service_use_cohorts_path.Rd # man/get_sg_homelessness_pub_path.Rd
Collaborator
Author
|
TODO: See PR from @LucyEmma22 #1327 Should also include logs for CH costs on this PR. |
| if (isTRUE(BYOC_MODE)) { | ||
| ch_costs_path <- file.path( | ||
| denodo_output_path(), | ||
| stringr::str_glue("Cost_CH_Lookup.parquet") |
Collaborator
There was a problem hiding this comment.
we are now using cost_ch_lookup.parquet, changing everything to small letters for consistency. NSS's copy_to_s3 will take cost_ch_lookup.parquet as it has been effected on their end as small letters.
| ch_costs_path <- get_file_path( | ||
| directory = fs::path(get_slf_dir(), "Costs"), | ||
| file_name = stringr::str_glue( | ||
| "Cost_CH_Lookup.parquet" |
Collaborator
There was a problem hiding this comment.
same comment as above
|
|
||
| # Join data together ----------------------------------------------------- | ||
|
|
||
| ## TODO - do we still continue with this check? |
Collaborator
There was a problem hiding this comment.
No needed to continue. The data created is used to generate the graph which we no longer check.
Jennit07
commented
Jun 8, 2026
Comment on lines
+24
to
+28
| sc_demog_lookup = read_file(get_sc_demog_lookup_path(BYOC_MODE)), | ||
| refined_death = read_file(get_combined_slf_deaths_lookup_path(BYOC_MODE)), | ||
| BYOC_MODE = FALSE, | ||
| run_id = NA, | ||
| run_date_time = NA, |
Collaborator
Author
There was a problem hiding this comment.
This pc lookup should be specified as a parameter here
uk_pc_directory <- get_uk_postcode_data(BYOC_MODE)
lizihao-anu
reviewed
Jun 8, 2026
| ... | ||
| ) | ||
|
|
||
| get_ch_costs_path <- function(BYOC_MODE..., update = NULL) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| get_ch_costs_path <- function(BYOC_MODE..., update = NULL) { | |
| get_ch_costs_path <- function(BYOC_MODE, ...) { |
remove update as this is redundant. Also need to check where this update parameter is used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP - #1299
Refactoring of ALL care homes and FY care homes
As Care Homes and SC Demographics are interlinked, this PR must be merged into #1313 first before merging into the
developmentbranch for testing.TODO:
Data not ready in SDL - On hold for testing locally/in BYOC