BYOC_ID: 46896 - Refactor gpprac lookup#1335
Conversation
OluwatobiOni
requested review from
Jennit07 and
lizihao-anu
and removed request for
lizihao-anu
OluwatobiOni
added
On hold
Jennit07
changed the title
| postcode = phsmethods::format_postcode(.data$postcode) | ||
| ) %>% | ||
| dplyr::distinct(.data$gpprac, .keep_all = TRUE) %>% |
There was a problem hiding this comment.
Do we also need these lines after line 15(denodo connection)?
| dplyr::select( | ||
| gpprac = "praccode", | ||
| pc7 = "postcode" | ||
| ) %>% | ||
| dplyr::mutate( | ||
| pc7 = phsmethods::format_postcode(.data$pc7, format = "pc7") | ||
| ) |
There was a problem hiding this comment.
Wondering if we also need this above after reading the denodo connection/table?
| gpprac_ref_file <- get_gpprac_ref_data(BYOC_MODE = BYOC_MODE) | ||
| open_data <- get_gpprac_opendata(BYOC_MODE = BYOC_MODE) | ||
| spd_file <- get_spd_data(BYOC_MODE = BYOC_MODE) %>% |
There was a problem hiding this comment.
Could we put all 3 of these into the parameters of the function please?
| gpprac_ref_file <- get_gpprac_ref_data(BYOC_MODE = BYOC_MODE) | ||
| open_data <- get_gpprac_opendata(BYOC_MODE = BYOC_MODE) | ||
| spd_file <- get_spd_data(BYOC_MODE = BYOC_MODE) %>% |
There was a problem hiding this comment.
| gpprac_ref_file <- get_gpprac_ref_data(BYOC_MODE = BYOC_MODE) | |
| open_data <- get_gpprac_opendata(BYOC_MODE = BYOC_MODE) | |
| spd_file <- get_spd_data(BYOC_MODE = BYOC_MODE) %>% | |
| gpprac_ref_file <- gpprac_ref_file | |
| gpprac_open_data <- gpprac_open_data | |
| spd_file <- spd_data %>% |
This is what the code would look like if those files were added into the functions parameter above
There was a problem hiding this comment.
suggested one rename here to make it a bit more clear what open data we are using
Jennit07
left a comment
Jennit07
left a comment
There was a problem hiding this comment.
Hi @OluwatobiOni Overall the PR looks good, thanks for your hard work! I have a few minor suggestions. I'm happy to have another look/test again when the data is available to us! Thanks :)
Jennit07
added
ready for PHS testing
PR complete
and removed
PR ready for review
labels
2 participants
TO-DOs: