Add serial rotary encoder and api endpoint#115
Merged
Conversation
Benjamin-Nussbaum
force-pushed
the
simple-rotary-encoder
branch
from
ca43e9c to
7fe0a22
Compare
marcosfrenkel
approved these changes
Oct 3, 2025
Comment on lines
+43
to
+45
| rotary_encoder: SerialRotaryEncoder = SerialRotaryEncoder( | ||
| label="rotary_encoder", address="/dev/ttyACM0", offset_degrees=0.0 | ||
| ) |
Collaborator
There was a problem hiding this comment.
Is this the automatic discovery of the serial address? What happens if the pi doesn't have this address?
marcosfrenkel
force-pushed
the
simple-rotary-encoder
branch
from
7fe0a22 to
b4bdb65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.