Skip to content

Conversation

@Kleissner
Copy link

Implement the code for #69 Parsing image tags to include them in crawling.
By default the new setting ParseImageTags is set to false, so the current default behavior does not change.

@mna
Copy link
Member

mna commented Oct 27, 2019

Hello Peter,

Thanks for the PR, makes sense and looks good to me, could you just add a unit test that exercises that new feature (w.opts.ParseImageTags set to true, and checking that image source URLs have actually been added to the crawler)?

Thanks,
Martin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants