fix(attributes): extract default attributes from DefaultAttributes#44
Open
MarkPLacer wants to merge 2 commits intoPumpkin-MC:masterfrom
Open
fix(attributes): extract default attributes from DefaultAttributes#44MarkPLacer wants to merge 2 commits intoPumpkin-MC:masterfrom
MarkPLacer wants to merge 2 commits intoPumpkin-MC:masterfrom
Conversation
MarkPLacer
force-pushed
the
fix-player-attributes
branch
from
fb33c20 to
456e63e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extractor currently relies on
EntityType.create()to inspect entity data. For entities likePlayer,create()can returnnullbecause aGameProfileis required, which causes player attributes to be skipped entirely during extraction.This change reads default base attributes from vanilla's
DefaultAttributessupplier when available, which is the actual source of truth for living entity defaults.The extracted
attributesfield keeps the existingentities.jsonshape used downstream by Pumpkin codegen; this PR only fixes missing data for entities whose defaults are present inDefaultAttributesbut whose runtime instance cannot be created here.This is the upstream root cause behind Pumpkin-MC/Pumpkin#1990. The Pumpkin PR fixes the generated data downstream; this PR fixes the extraction step so future regenerations include player attributes correctly.