refactor: migrate the Flutter plugin to the Purchasely 6.0 native SDK

[kherembourg]

Summary

Adapts the Flutter plugin to the Purchasely 6.0 native SDK. This is a migration of the existing plugin — same public surface as before, just updated for 6.0 — not a rewrite. There is no separate "v6" module and no v6/V6 symbol anywhere: each platform keeps a single FlutterPlugin, and the Dart code keeps the lib/src/ split.

What changed

• start, presentation (preload/display/close/back) and the action interceptor now call the native 6.0 API. Their implementations were folded back into the single plugin per platform (SwiftPurchaselyFlutterPlugin.swift, PurchaselyFlutterPlugin.kt) — the temporary PurchaselyV6Bridge.{swift,kt} is removed.
• Every other method is kept (purchases, restore, identity, user attributes, products/plans, subscriptions data, events, dynamic offerings, consent, config) and adapted where the 6.0 API changed a signature (allowDeeplink, handleDeeplink, isEligibleToOffer, storeOfferId, userLogout(true), …).
• Inline native view (NativeView/NativeViewFactory + native_view_widget.dart) kept and adapted to 6.0 (built from a loaded presentation keyed by requestId).
• Dart (lib/src/ split kept): dispatcher renamed PurchaselyV6Bridge → PurchaselyBridge; V6RunningMode/V6LogLevel → RunningMode/LogLevel; MethodChannel verbs un-prefixed; the presentation/interceptor stream is EventChannel('purchasely-presentation-events'); request_id.dart inlined. The legacy Purchasely class drops only the old start/presentation/interceptor methods (now provided by the builders); the example v6_demo_screen.dart → presentation_demo_screen.dart.

Removed

• Android: PLYProductActivity + PLYSubscriptionsActivity — the 6.0 Android SDK no longer exposes the built-in subscriptions screen, so presentSubscriptions is a no-op on Android (still works on iOS).
• iOS: 3 dead v5 presentation/interceptor +ToMap extensions whose types changed/disappeared in 6.0 (PLYPlan/PLYProduct/PLYSubscription/PLYOfferSignature +ToMap are kept).

Native SDK dependency status

• Android — requires io.purchasely:core:6.0.0, not yet on Maven Central; resolved from mavenLocal() for local builds.
• iOS — requires Purchasely 6.0.0, not yet on CocoaPods trunk (trunk tops out at 5.7.x); the 6.0 API lives on the iOS SDK develop branch and is consumed locally via a :path dev-pod. The example's iOS build config (Podfile dev-pod, deployment target 15.0) is intentionally kept local / uncommitted (machine-specific).
• ⇒ The native CI jobs (Build / Unit Tests, Android & iOS) stay red until 6.0.0 is published to the package registries; the Dart jobs are green. Remove mavenLocal() and the iOS :path dev-pod once 6.0.0 ships.

Test plan / verification

• flutter analyze (package + example) — 0 errors
• flutter test — 209 pass
• ./gradlew :purchasely_flutter:compileDebugKotlin — BUILD SUCCESSFUL (against core:6.0.0 from mavenLocal)
• flutter build ios --simulator — Built (against the Purchasely 6.0.0 dev-pod)
• Native Android JUnit + iOS XCTest in CI — pending 6.0.0 publish

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This PR introduces the v6 cross-platform bridge: a new Dart façade (PresentationBuilder, PresentationRequest, Presentation, PresentationOutcome, typed action interceptors) backed by native bridges in Kotlin (507 lines) and Swift (525 lines), all wired through a shared purchasely MethodChannel and a dedicated purchasely/v6-events EventChannel. The v5 surface remains untouched, making this entirely opt-in.

• Dart bridge (lib/src/bridge.dart) manages in-flight request entries keyed by requestId, correctly handles preload → display → dismiss → re-display lifecycle (regression tested), and routes typed interceptor invocations to Dart handlers with async resolve back to native.
• Android bridge correctly maps all PLYTransitionType values (including inlinePaywall), uses ConcurrentHashMap for thread safety, and emits outcomes via the EventChannel rather than the MethodChannel result — matching the Dart dispatcher's expectation.
• iOS bridge synthesises the 5-field outcome contract on top of the 2-field native PLYPresentationOutcome, but the display-error synthesis path (P0.4) has a timing issue: events are dispatched async while the MethodChannel error is synchronous, causing the Dart entry to be removed before the onPresented(nil, error) callback can fire.

Confidence Score: 4/5

Safe to merge as an opt-in v6 façade; the v5 surface is untouched. One real defect in the iOS display-error path means builder-registered onPresented callbacks silently don't fire when display fails on iOS, though the Future-based API resolves correctly.

The iOS bridge's display error path calls result(FlutterError) synchronously while emitting onPresented/onDismissed events asynchronously via DispatchQueue.main.async. The Dart PlatformException handler removes the request entry before the async events are processed, so the P0.4 onPresented(nil, error) synthesis never reaches the builder callback. Developers relying on builder callbacks for error notification on iOS get silent failures.

purchasely/ios/Classes/PurchaselyV6Bridge.swift — the display-error completion block (lines 272–299) should call result(true) instead of result(FlutterError) and let the already-emitted onDismissed event carry the error to Dart, matching Android's event-only outcome delivery.

Important Files Changed

Filename	Overview
purchasely/ios/Classes/PurchaselyV6Bridge.swift	iOS bridge synthesising the 5-field contract. Display-error path emits events via DispatchQueue.main.async but calls result(FlutterError) synchronously, so P0.4 onPresented(nil,error) callbacks are silently swallowed by the Dart PlatformException handler. Also hardcodes NSNull() for contentId.
purchasely/android/src/main/kotlin/io/purchasely/purchasely_flutter/PurchaselyV6Bridge.kt	Android bridge implementing the full v6 contract. displayCallbacks entry leaks on synchronous display errors; loadedPresentations/preparedRequests grow unboundedly across the session. Logic is otherwise correct.
purchasely/lib/src/bridge.dart	Core Dart dispatcher wiring MethodChannel/EventChannel to the v6 façade. Entry lifecycle (register, re-display, dismiss) is solid; the PlatformException guard prevents double-completion. No new issues found.
purchasely/lib/src/action_interceptor.dart	Typed action payload hierarchy and wire serialisation. Consistent with both native bridges; null-guarded parsing for required fields.
purchasely/test/bridge_test.dart	5 new integration tests covering preload, display, callbacks, interceptor lifecycle, and re-display regression. Good coverage of the happy path and the previously-flagged re-display hang.
purchasely/lib/src/presentation_outcome.dart	5-field outcome model with correct closeReason/error mutual-exclusion semantics; handles both camelCase and snake_case variants for backSystem.

Sequence Diagram

sequenceDiagram
    participant App as Flutter App
    participant Dart as PurchaselyV6Bridge (Dart)
    participant MC as MethodChannel purchasely
    participant EC as EventChannel purchasely/v6-events
    participant Native as Native Bridge Android/iOS

    App->>Dart: display()
    Dart->>MC: "v6/display {requestId, transition}"
    MC->>Native: handle v6/display
    Native-->>MC: result(true)
    MC-->>Dart: invokeMethod resolves OK
    Note over Dart: completer stored awaiting dismiss
    Native-->>EC: "onPresented {requestId, presentation}"
    EC-->>Dart: _handleOnPresented fires callback
    Native-->>EC: "onDismissed {requestId, outcome}"
    EC-->>Dart: completer.complete(outcome)
    Dart-->>App: Future resolves with PresentationOutcome
    Note over Native,Dart: iOS error path P0.4 issue
    Native-->>EC: onPresented nil error async main queue
    Native-->>EC: onDismissed error outcome async main queue
    Native-->>MC: result(FlutterError) synchronous
    MC-->>Dart: PlatformException entry removed completer complete
    EC-->>Dart: onPresented arrives entry null SKIPPED
    EC-->>Dart: onDismissed arrives entry null SKIPPED

Loading

Prompt To Fix All With AI

Fix the following 4 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 4
purchasely/ios/Classes/PurchaselyV6Bridge.swift:272-299
**P0.4 onPresented synthesis never fires on iOS display errors**

`events.emit(...)` wraps its payload in `DispatchQueue.main.async`, so the `onPresented` and `onDismissed` events are queued for a future run-loop iteration. But `result(FlutterError(...))` is called synchronously in the same closure and is processed first by Dart. The `_displayPresentation`/`_displayRequest` PlatformException handler removes the entry from `_entries` and completes the dismiss completer before either async event is delivered. When the events eventually arrive, `_handleOnPresented` and `_handleOnDismissed` find `entry == null` and return early — the builder's `onPresented(nil, error)` callback never fires.

Changing the error path to call `result(true)` instead of `result(FlutterError(...))` would let both events be processed while the entry is still live, matching the behavior documented in BRIDGE-CONTRACT P0.4 and aligning with Android's event-only outcome delivery.

### Issue 2 of 4
purchasely/ios/Classes/PurchaselyV6Bridge.swift:386
**iOS `contentId` always serialised as `null`**

All other optional fields (`placementId`, `audienceId`, `abTestId`, etc.) pass through their `PLYPresentation` values with `as Any`, but `contentId` is unconditionally `NSNull()`. If `PLYPresentation` exposes a `contentId` property in the v6 SDK, this silently drops the value; `Presentation.contentId` will always be `nil` on iOS even when the backend set one.

```suggestion
            "contentId": p.contentId as Any,  // TODO: verify contentId is exposed in v6 SDK
```

### Issue 3 of 4
purchasely/android/src/main/kotlin/io/purchasely/purchasely_flutter/PurchaselyV6Bridge.kt:264-275
**`displayCallbacks` entry leaks on synchronous display error**

`displayCallbacks[requestId]` is set before the `try` block. If `prepared.display(...)` throws synchronously, the catch block calls `result.error(...)` but never removes the `displayCallbacks[requestId]` entry. The key lives in the map indefinitely, holding a no-op lambda. Adding `displayCallbacks.remove(requestId)` inside the catch block closes the leak.

### Issue 4 of 4
purchasely/android/src/main/kotlin/io/purchasely/purchasely_flutter/PurchaselyV6Bridge.kt:209-218
**`loadedPresentations` and `preparedRequests` grow unboundedly**

`loadedPresentations[requestId]` is populated in `v6Preload` and `preparedRequests[requestId]` in `buildPrepared`, but neither map is pruned when a presentation is dismissed (`buildPrepared.onDismissed` only removes from `displayCallbacks`). Because `nextRequestId()` generates a fresh UUID for every `PresentationBuilder.build()` call, each displayed presentation leaves a permanent `PLYPresentation` reference for the lifetime of the bridge. The same applies to `presentations` on the iOS side.

_{Reviews (3): Last reviewed commit: "chore(dart): apply dart format to v6 dem..." | Re-trigger Greptile}

[kherembourg]

@greptileai review

---

Generated by Claude Code

[kherembourg]

@greptileai review

[greptile-apps]

P0.4 onPresented synthesis never fires on iOS display errors

events.emit(...) wraps its payload in DispatchQueue.main.async, so the onPresented and onDismissed events are queued for a future run-loop iteration. But result(FlutterError(...)) is called synchronously in the same closure and is processed first by Dart. The _displayPresentation/_displayRequest PlatformException handler removes the entry from _entries and completes the dismiss completer before either async event is delivered. When the events eventually arrive, _handleOnPresented and _handleOnDismissed find entry == null and return early — the builder's onPresented(nil, error) callback never fires.

Changing the error path to call result(true) instead of result(FlutterError(...)) would let both events be processed while the entry is still live, matching the behavior documented in BRIDGE-CONTRACT P0.4 and aligning with Android's event-only outcome delivery.

Prompt To Fix With AI

This is a comment left during a code review.
Path: purchasely/ios/Classes/PurchaselyV6Bridge.swift
Line: 272-299

Comment:
**P0.4 onPresented synthesis never fires on iOS display errors**

`events.emit(...)` wraps its payload in `DispatchQueue.main.async`, so the `onPresented` and `onDismissed` events are queued for a future run-loop iteration. But `result(FlutterError(...))` is called synchronously in the same closure and is processed first by Dart. The `_displayPresentation`/`_displayRequest` PlatformException handler removes the entry from `_entries` and completes the dismiss completer before either async event is delivered. When the events eventually arrive, `_handleOnPresented` and `_handleOnDismissed` find `entry == null` and return early — the builder's `onPresented(nil, error)` callback never fires.

Changing the error path to call `result(true)` instead of `result(FlutterError(...))` would let both events be processed while the entry is still live, matching the behavior documented in BRIDGE-CONTRACT P0.4 and aligning with Android's event-only outcome delivery.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!