Fix missing ModelBinder for outputFormatParams in GetTableDataByPost#538
Merged
likp merged 1 commit intoPxTools:mainfrom Feb 17, 2026
Merged
Fix missing ModelBinder for outputFormatParams in GetTableDataByPost#538likp merged 1 commit intoPxTools:mainfrom
likp merged 1 commit intoPxTools:mainfrom
Conversation
avocodetoast
requested review from
JohannesFinsveen,
MikaelNordberg,
likp,
oyessb and
runejo
as code owners
likp
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST requests to the data endpoint return 400 when multiple outputFormatParams are specified in the query string (e.g. outputFormatParams=UseTexts,IncludeTitle), while the same query works fine with GET.
The cause is that GetTableDataByPost is missing the ModelBinder(typeof(OutputFormatParamsModelBinder)) attribute on the outputFormatParams parameter, which GetTableData (GET) has. Without it, ASP.NET Core falls back to default binding, which cannot handle comma-separated enum values.
Fix: add the missing attribute, consistent with the GET endpoint.