feat: add binding for "avcodec_find_best_pix_fmt_of_list" #2058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to test for which pixel format to target before conversion without actively running filters or similar. - added logic / tests / type hints for avcodec_find_best_pix_fmt_of_list - named it on python's side: find_best_pix_fmt_of_list
- forgot to run ruff linter before - removed a forgottent space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds binding for
find_best_pix_fmt_of_list, to the codec module.The function helps determine the best pixel format for conversion given a source format and a list of candidates, and reports potential information loss. It helps do it without actually running a filter (such as the
formatfilter), which is heavy and unnecessary when you just want the information as fast as possible in python...Actual implementation:
av/codec/codec.pyx, wrapping FFmpeg'savcodec_find_best_pix_fmt_of_list, . Added the corresponding Cython extern declaration foravcodec_find_best_pix_fmt_of_listininclude/libavcodec/avcodec.pxd.find_best_pix_fmt_of_listto the public API inav/codec/__init__.pyand documented its signature and behavior in the type stubav/codec/codec.pyi. It handles both string andVideoFormatinputs.Testing:
tests/test_codec.pyto verify correct behavior, edge cases, and error handling forfind_best_pix_fmt_of_list.