refactor: remove dead non_linear + visualize/include config (PyAutoBrain#155)#88
Merged
Merged
Conversation
Two dead-config clusters found by the reachability-based orphan-config-file check (PyAutoBrain#155): config/non_linear/{nest,mle,mcmc}.yaml (searches default from Python signatures, not these yamls; only GridSearch.yaml is live) and config/visualize/include.yaml (no library ships it, nothing reads conf visualize.include, no Include2D class, user-facing workspaces dropped it). Same class as autolens_workspace#317's grids.yaml.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of PyAutoBrain#155 — removes dead orphan config surfaced by the new reachability-based
/hygiene configcheck.config/non_linear/{nest,mle,mcmc}.yamlis dead: nothing readsconf.instance["non_linear"]for them. Non-linear searches take their defaults from their Python constructor signatures (Nautilusn_live=3000inautofit/non_linear/search/nest/nautilus/search.py), while these yamls sayn_live=200and have no effect. No library ships them; the only live file in the directory isGridSearch.yaml, which stays.Same defect class as the
grids.yamlremoval (autolens_workspace#317). Verified after deletion thatconf.instance["non_linear"]still resolves (gridsearchkept) and config loading is unbroken.Also removes
config/visualize/include.yaml— dead for the same reason (no library ships it, nothing readsconf.instance["visualize"]["include"], noInclude2Dclass, user-facing workspaces already dropped it).