Skip to content

Conversation

@lgiacome
Copy link

With this PR we add the possibility to specify if the mpi-parallel version of PyHEADTAIL should be used by addidng a command line flag to setup.py.

For the moment we just add mpi4py as one to the requirements if the flag is specified.

@lgiacome
Copy link
Author

lgiacome commented Aug 30, 2022

@lmether I've noticed we use the setup_requires argument of setuptools.setup for the dependencies while most other codes seem to use install_requires. Do you think this is done on purpose?

@lmether
Copy link
Collaborator

lmether commented Aug 30, 2022

I'm not sure if this was originally done on purpose. On the other hand, looking at the Makefile, it seems that we don't run setup.py install at all when compiling manually, we just build the extensions, so maybe that is the reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants