Skip to content

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 16, 2023

I think these two dependencies do not need to be specified in pyproject.toml:

  1. setuptools_scm_git_archive does not seem to be needed unless a .git_archival.txt file exists
  2. wheel does not need to be specified: setuptools defines a get_requires_for_build_wheel function in its build backend that does this automatically

@tjni tjni requested a review from ssbarnea as a code owner August 16, 2023 05:31
@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Feb 15, 2024
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a git archival file, would help people wanting to install from git archive.

@ssbarnea ssbarnea merged commit 34c98f7 into PyCQA:main Sep 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue/PR relates to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants