Skip to content

Move project to >= 3.9 #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

Move project to >= 3.9 #507

merged 2 commits into from
Mar 31, 2025

Conversation

cooperlees
Copy link
Collaborator

  • CI failed as we'd hoped and it's time to move to >= 3.9 cpython to match flake8
  • Here we update all configuration and metadata etc. etc.

This fixes "flake8_py_version_check" CI failing like: https://github.com/PyCQA/flake8-bugbear/actions/runs/14150950748/job/39644039034

@cooperlees
Move project to >= 3.9
6e8ec19 
- CI failed as we'd hoped and it's time to move to >= 3.9 cpython
  to match flake8
- Here we update all configuration and metadata etc. etc.

This fixes "flake8_py_version_check" CI failing like:
https://github.com/PyCQA/flake8-bugbear/actions/runs/14150950748/job/39644039034
@cooperlees cooperlees requested a review from Copilot March 30, 2025 03:40
Copilot
Copilot AI reviewed Mar 30, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates project configurations to require Python >=3.9, aligning the project metadata and CI pipeline accordingly.

  • Removed the Python 3.8 classifier from pyproject.toml.
  • Updated the required Python version and dependency versions in pyproject.toml.
  • Removed Python 3.8 from the CI workflow’s python-version matrix.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
pyproject.toml Updated classifiers, required Python version, and dependency versions to reflect support for >=3.9.
.github/workflows/ci.yml Adjusted the Python version matrix to remove Python 3.8, ensuring CI alignment with project changes.
Files not reviewed (1)
  • README.rst: Language not supported

@cooperlees cooperlees requested a review from Copilot March 30, 2025 03:40
Copilot
Copilot AI reviewed Mar 30, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to require Python 3.9 or higher, addressing CI failures due to outdated Python version configurations.

  • Removed Python 3.8 classifier and updated the "requires-python" field in pyproject.toml.
  • Updated dependency constraints (flake8 version) in pyproject.toml.
  • Adjusted the CI workflow matrix to remove Python 3.8.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
pyproject.toml Removes Python 3.8 support and updates dependency versions.
.github/workflows/ci.yml Updates the Python version matrix to start from 3.9 instead of 3.8.
Files not reviewed (1)
  • README.rst: Language not supported

@cooperlees cooperlees requested a review from Copilot March 30, 2025 03:41
Copilot
Copilot AI reviewed Mar 30, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to require Python >= 3.9 to align with flake8 requirements and improve dependency management.

  • Updated classifiers and requires-python in pyproject.toml to reflect Python 3.9+.
  • Adjusted CI workflow matrix to remove Python 3.8.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
pyproject.toml Removed Python 3.8 classifier; updated requires-python and flake8 dependency versions.
.github/workflows/ci.yml Updated CI matrix to remove Python 3.8 from tested versions.
Files not reviewed (1)
  • README.rst: Language not supported

@cooperlees cooperlees requested a review from Copilot March 30, 2025 03:41
Copilot
Copilot AI reviewed Mar 30, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates configuration files to require Python 3.9 or later, in order to fix CI failures related to flake8 and streamline our supported Python versions.

  • Updated Python classifiers and dependencies in pyproject.toml
  • Removed Python 3.8 from the CI workflow matrix

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
pyproject.toml Updated requires-python and dependencies; removed Python 3.8 classifier
.github/workflows/ci.yml Removed Python 3.8 from the CI matrix
Files not reviewed (1)
  • README.rst: Language not supported

@cooperlees cooperlees requested review from Copilot March 30, 2025 03:42
Copilot
Copilot AI reviewed Mar 30, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project configuration to support Python versions >= 3.9 in order to resolve the flake8_py_version_check failures.

  • Removed Python 3.8 references in classifiers and adjusted the requires-python field in pyproject.toml.
  • Updated dependencies and the python version matrix in the CI workflow to reflect the new minimum version.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
pyproject.toml Removed Python 3.8 classifiers, updated requires-python, dependencies
.github/workflows/ci.yml Adjusted python version matrix, removing Python 3.8
Files not reviewed (1)
  • README.rst: Language not supported

JelleZijlstra
JelleZijlstra approved these changes Mar 30, 2025
View reviewed changes
Copilot
Copilot AI reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot
Copilot AI reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@cooperlees @JelleZijlstra
Update README.rst
a6059a5 
Co-authored-by: Jelle Zijlstra <[email protected]>
@cooperlees cooperlees merged commit a9c4ae1 into main Mar 31, 2025
11 checks passed
@cooperlees cooperlees deleted the 3_9 branch March 31, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cooperlees @JelleZijlstra