Remove F821 monkey patch #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove --no-pyi-aware-file-checker option Closes: PyCQA#522
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Alex Waygood <[email protected]>
This comment has been minimized.
This comment has been minimized.
AlexWaygood
approved these changes
Sep 30, 2025
flake8_pyi/checker.py
Outdated
|
|
||
| @staticmethod | ||
| def add_options(parser: OptionManager) -> None: | ||
| """This is brittle, there's multiple levels of caching of defaults.""" |
There was a problem hiding this comment.
I sort of worry that nobody on the current maintainers team knows what this cryptic comment is actually referring to ¯\_(ツ)_/¯
There was a problem hiding this comment.
(Unless @ambv remembers what he meant with that comment. It's only been 10 years, after all.)
|
This change has no effect on typeshed. 🤖🎉 |
AlexWaygood
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove --no-pyi-aware-file-checker option
Closes: #522