Skip to content

update versions of pycodestyle / pyflakes #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2025
Merged

update versions of pycodestyle / pyflakes #1974

merged 1 commit into from
Mar 29, 2025

Conversation

asottile
Copy link
Member

No description provided.

@asottile asottile merged commit ebad305 into main Mar 29, 2025
11 checks passed
@asottile asottile deleted the update-plugins branch March 29, 2025 19:46
@asottile asottile added this to the 7.2.0 milestone Mar 29, 2025
fnordahl added a commit to fnordahl/ovs that referenced this pull request Mar 30, 2025
@fnordahl
python: Disable global statement where the name is never reassigned c…
eb41c1d 
…heck (F824).

flake8 2.7.0 introduced the F824 check [0].

While the check sounds reasonable on the surface, we have code in
the repository where the global variable is used only for access.

My conclusion from evaluating the alternative of adjusting the code
to appease the check is that it would invite future mistakes where
the global variable is unintentionally shadowed in addition to
making the code less clear and explicit.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
ovsrobot pushed a commit to ovsrobot/ovs that referenced this pull request Mar 30, 2025
@fnordahl @ovsrobot
python: Disable global statement where the name is never reassigned c…
6a4311f 
…heck (F824).

flake8 2.7.0 introduced the F824 check [0].

While the check sounds reasonable on the surface, we have code in
the repository where the global variable is used only for access.

My conclusion from evaluating the alternative of adjusting the code
to appease the check is that it would invite future mistakes where
the global variable is unintentionally shadowed in addition to
making the code less clear and explicit.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: 0-day Robot <[email protected]>
igsilya pushed a commit to igsilya/ovs that referenced this pull request Mar 30, 2025
@fnordahl @igsilya
python: Disable check for globals with never reassigned names (F824).
7f4ee43 
flake8 2.7.0 introduced the F824 check [0].

While the check sounds reasonable on the surface, we have code in
the repository where the global variable is used only for access.

My conclusion from evaluating the alternative of adjusting the code
to appease the check is that it would invite future mistakes where
the global variable is unintentionally shadowed in addition to
making the code less clear and explicit.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
igsilya pushed a commit to igsilya/ovs that referenced this pull request Mar 30, 2025
@fnordahl @igsilya
python: Disable check for globals with never reassigned names (F824).
bb05933 
flake8 2.7.0 introduced the F824 check [0].

While the check sounds reasonable on the surface, we have code in
the repository where the global variable is used only for access.

My conclusion from evaluating the alternative of adjusting the code
to appease the check is that it would invite future mistakes where
the global variable is unintentionally shadowed in addition to
making the code less clear and explicit.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
igsilya pushed a commit to igsilya/ovs that referenced this pull request Mar 30, 2025
@fnordahl @igsilya
python: Disable check for globals with never reassigned names (F824).
9101ec5 
flake8 2.7.0 introduced the F824 check [0].

While the check sounds reasonable on the surface, we have code in
the repository where the global variable is used only for access.

My conclusion from evaluating the alternative of adjusting the code
to appease the check is that it would invite future mistakes where
the global variable is unintentionally shadowed in addition to
making the code less clear and explicit.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
igsilya pushed a commit to igsilya/ovs that referenced this pull request Mar 30, 2025
@fnordahl @igsilya
python: Disable check for globals with never reassigned names (F824).
9f1d6a8 
flake8 2.7.0 introduced the F824 check [0].

While the check sounds reasonable on the surface, we have code in
the repository where the global variable is used only for access.

My conclusion from evaluating the alternative of adjusting the code
to appease the check is that it would invite future mistakes where
the global variable is unintentionally shadowed in addition to
making the code less clear and explicit.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
igsilya pushed a commit to igsilya/ovs that referenced this pull request Mar 30, 2025
@fnordahl @igsilya
python: Disable check for globals with never reassigned names (F824).
1f3232b 
flake8 2.7.0 introduced the F824 check [0].

While the check sounds reasonable on the surface, we have code in
the repository where the global variable is used only for access.

My conclusion from evaluating the alternative of adjusting the code
to appease the check is that it would invite future mistakes where
the global variable is unintentionally shadowed in addition to
making the code less clear and explicit.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
fnordahl added a commit to fnordahl/ovn that referenced this pull request Mar 31, 2025
@fnordahl
ovs: Update OVS submodule.
b862d85 
Building the OVS submodule is currently broken for the OVN CI due
to a change in flake8 2.7.0 which introduced the F824 check [0][1].

This was tackled in OVS commit 7f4ee4395637 by disabling the check.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
ovsrobot pushed a commit to ovsrobot/ovn that referenced this pull request Mar 31, 2025
@fnordahl @ovsrobot
ovs: Update OVS submodule.
9893a92 
Building the OVS submodule is currently broken for the OVN CI due
to a change in flake8 2.7.0 which introduced the F824 check [0][1].

This was tackled in OVS commit 7f4ee4395637 by disabling the check.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: 0-day Robot <[email protected]>
dceara pushed a commit to dceara/ovn that referenced this pull request Mar 31, 2025
@fnordahl @dceara
ovs: Update OVS submodule.
94c8a4c 
Building the OVS submodule is currently broken for the OVN CI due
to a change in flake8 2.7.0 which introduced the F824 check [0][1].

This was tackled in OVS commit 7f4ee4395637 by disabling the check.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Acked-by: Ales Musil <[email protected]>
Signed-off-by: Dumitru Ceara <[email protected]>
dceara pushed a commit to dceara/ovn that referenced this pull request Mar 31, 2025
@fnordahl @dceara
ovs: Update OVS submodule.
03077a4 
Building the OVS submodule is currently broken for the OVN CI due
to a change in flake8 2.7.0 which introduced the F824 check [0][1].

This was tackled in OVS commit 7f4ee4395637 by disabling the check.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Acked-by: Ales Musil <[email protected]>
Signed-off-by: Dumitru Ceara <[email protected]>
(cherry picked from commit 94c8a4c)
dceara pushed a commit to dceara/ovn that referenced this pull request Mar 31, 2025
@fnordahl @dceara
ovs: Update OVS submodule.
96906b3 
Building the OVS submodule is currently broken for the OVN CI due
to a change in flake8 2.7.0 which introduced the F824 check [0][1].

This was tackled in OVS commit 7f4ee4395637 by disabling the check.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Acked-by: Ales Musil <[email protected]>
Signed-off-by: Dumitru Ceara <[email protected]>
(cherry picked from commit 94c8a4c)
dceara pushed a commit to dceara/ovn that referenced this pull request Mar 31, 2025
@fnordahl @dceara
ovs: Update OVS submodule.
4441d4e 
Building the OVS submodule is currently broken for the OVN CI due
to a change in flake8 2.7.0 which introduced the F824 check [0][1].

This was tackled in OVS commit 7f4ee4395637 by disabling the check.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Acked-by: Ales Musil <[email protected]>
Signed-off-by: Dumitru Ceara <[email protected]>
(cherry picked from commit 94c8a4c)
dceara pushed a commit to dceara/ovn that referenced this pull request Mar 31, 2025
@fnordahl @dceara
ovs: Update the submodule to include python F824 fix.
f68cc0c 
Building the OVS submodule is currently broken for the OVN CI due
to a change in flake8 2.7.0 which introduced the F824 check [0][1].

This was tackled in OVS commit 7f4ee4395637 by disabling the check.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Acked-by: Ales Musil <[email protected]>
Signed-off-by: Dumitru Ceara <[email protected]>
dceara pushed a commit to dceara/ovn that referenced this pull request Mar 31, 2025
@fnordahl @dceara
ovs: Update the submodule to include python F824 fix.
d0143b7 
Building the OVS submodule is currently broken for the OVN CI due
to a change in flake8 2.7.0 which introduced the F824 check [0][1].

This was tackled in OVS commit 7f4ee4395637 by disabling the check.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Acked-by: Ales Musil <[email protected]>
Signed-off-by: Dumitru Ceara <[email protected]>
(cherry picked from commit f68cc0c)
dceara pushed a commit to dceara/ovn that referenced this pull request Mar 31, 2025
@fnordahl @dceara
ovs: Update the submodule to include python F824 fix.
561a46e 
Building the OVS submodule is currently broken for the OVN CI due
to a change in flake8 2.7.0 which introduced the F824 check [0][1].

This was tackled in OVS commit 7f4ee4395637 by disabling the check.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Acked-by: Ales Musil <[email protected]>
Signed-off-by: Dumitru Ceara <[email protected]>
(cherry picked from commit f68cc0c)
dceara pushed a commit to dceara/ovn that referenced this pull request Mar 31, 2025
@fnordahl @dceara
ovs: Update the submodule to include python F824 fix.
fc4a72c 
Building the OVS submodule is currently broken for the OVN CI due
to a change in flake8 2.7.0 which introduced the F824 check [0][1].

This was tackled in OVS commit 7f4ee4395637 by disabling the check.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Acked-by: Ales Musil <[email protected]>
Signed-off-by: Dumitru Ceara <[email protected]>
(cherry picked from commit f68cc0c)
@thehrh thehrh mentioned this pull request Apr 11, 2025
Merged
martinmo pushed a commit to martinmo/ovs that referenced this pull request Apr 22, 2025
@fnordahl @martinmo
python: Disable check for globals with never reassigned names (F824).
65bcf31 
flake8 2.7.0 introduced the F824 check [0].

While the check sounds reasonable on the surface, we have code in
the repository where the global variable is used only for access.

My conclusion from evaluating the alternative of adjusting the code
to appease the check is that it would invite future mistakes where
the global variable is unintentionally shadowed in addition to
making the code less clear and explicit.

0: PyCQA/flake8#1974
1: PyCQA/pyflakes#825
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
(cherry picked from commit 7f4ee43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@asottile