Remove Safety #2373
Merged
Remove Safety #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2373 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 40 40
Lines 3101 3101
Branches 680 680
=======================================
Hits 3075 3075
Misses 15 15
Partials 11 11 |
cclauss
approved these changes
Feb 21, 2025
DanielNoord
reviewed
Feb 21, 2025
Comment on lines
+25
to
+31
| 1. Clone your fork to your local file system: | ||
| `git clone https://github.com/$GITHUB_ACCOUNT/isort.git` | ||
| 3. `cd isort` | ||
| 4. `uv sync --all-extras --frozen` | ||
| 1. `cd isort` | ||
| 1. `uv sync --all-extras --frozen` | ||
| * Optionally, isolate uv's installation from the rest of your system using the instructions on the uv site here: https://docs.astral.sh/uv/ | ||
| 5. `./scripts/test.sh` should yield Success: no issues found | ||
| 6. `./scripts/clean.sh` should yield a Safety report checking packages | ||
| 1. `./scripts/test.sh` should yield Success: no issues found | ||
| 1. `./scripts/clean.sh` should yield a report checking packages |
There was a problem hiding this comment.
We probably want to keep the numbers here 😄
There was a problem hiding this comment.
@DanielNoord a cool feature of Markdown is putting 1. to everything, it will automatically put the order for you. This makes easier to maintain and add other items to the list. But if you prefer I can revert it since it is not really related to Safety.
DanielNoord
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.