Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run slyp against the code base #2382

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kurtmckee
Copy link
Contributor

This addresses several formatting issues, including:

  • Same-line str concatenation
  • Same-indentation-level multi-line str concatenation in function parameters and dict definitions
  • Unnecessary parentheses around str constants

Although the initial work was automated, manual work was required to reflow multi-line concatenated strings to fit under the 100-character limit.

This addresses several formatting issues, including:

* Same-line str concatenation
* Same-indentation-level multi-line str concatenation
  in function parameters and dict definitions
* Unnecessary parentheses around str constants

Although the initial work was automated,
manual work was required to reflow multi-line
concatenated strings to fit under the 100-character limit.
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (3432318) to head (eb54f3c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2382   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          40       40           
  Lines        3101     3101           
  Branches      680      680           
=======================================
  Hits         3075     3075           
  Misses         15       15           
  Partials       11       11           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the old code reads fine to me. I don't really need parentheses for multi line strings, but that might be my personal preference.

The unnecessary concats are nice of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants