Repository navigation
build: add packaging, CI and release setup (1.5) - #7
Merged
Merged
Conversation
pyproject.toml with hatch-vcs, Python 3.11+ and the dual licence with license-files. Per D7 the author's template is the baseline (ruff, pre-commit, lychee, Makefile, CONTRIBUTING.md), with towncrier fragments in news/ and the test, changelog and release workflows taken from calendaring-jmap. SECURITY.md points at private vulnerability reporting. The sdist leaves out the prototypes and untracked tmp-* notes. A stub package and one test give pytest and the build something to run. Prompt: merge PR then start with 1.5 [merge #5, then start roadmap item 1.5] Followup-Prompt: The github pypi environment can probably be created using `gh`? Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
PyPI's trusted publisher for calendaring is registered for publish.yml, the name the author's project template uses, so the workflow file must carry that name for publishing to work. The 1.5 task in ROADMAP.md now names it. Prompt: Please set up the publish.yml also [the PyPI publishing workflow for roadmap 1.5] Followup-Prompt: it's publish.yml that is registered on pypi. I think that's the standard chosen in [my personal project template skill] ? Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Member
There was a problem hiding this comment.
Overall looks good to me, SHA pinning and trusted publishing are nice. Few things only:
- ruff 0.17.0 is out, CI and pre-commit are still on 0.16.8. And
devhasruff>=0.16without a pin, so new setup will pick 0.17, which reformats some imports, and then local and CI won't match. Better to pin one version everywhere. actions/setup-pythonv7.0.0 is out, PR is on v6.3.0. upload-artifact and download-artifact also have one patch release each.- It says
Typing :: Typedand shipspy.typed, but nothing checks types in CI. Can add a mypy job no? PIP_BREAK_SYSTEM_PACKAGES=1inmake devturns off pip's protection, so without a venv it goes into the system Python's user site. Maybe check for a venv and ask to create one instead?
Short on time so putting everything in one comment, instead of separate comments on each line.
Pin ruff exactly in the dev extra, at the pre-commit rev, and have the lint job install the dev extra rather than its own ruff pin, so local, pre-commit and CI run one version (0.17.0). The package claims to be typed, so the lint job now runs mypy --strict, checking as 3.11. setup-python, upload-artifact and download-artifact move to their latest releases; the other pins already were, and get exact version comments. make dev refuses to run outside a virtualenv instead of breaking PEP 668 into the user site. Review: #7 (review) from Sashank Prompt: Update the PR with those fixes. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Member
Author
|
Thanks! |
tobixen
added a commit
that referenced
this pull request
Oct 14, 2026
The I/O classes, bound items and the conformance suite are written async and the sync copies generated by unasync, which pulled 1.3's generator and freshness test forward. An in-memory reference backend passes the suite under four capability profiles (full, tracker-like, minimal, read-only), which between them run both branches of nearly every capability-aware test. Two features were added to the table: recurrence.edit-occurrence and task.complete-recurring. Prompt: Deal with the next ROADMAP item. Stack the PR on top of the boilerplate PR, if needed. [the next item was 1.2; the boilerplate PR is #7, branch roadmap-1.5] Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
added a commit
that referenced
this pull request
Oct 14, 2026
main now type-checks src and tests strictly. Task, Event and Journal declare their component as icalendar.Todo, Event and Journal, as their docstrings already said, and an item now refuses a hand-built plain Component that would break that. icalendar 7.3 leaves to_ical and vDDDTypes.from_ical unannotated, which gets narrow ignores. icalendar-searcher and recurring-ical-events are partly annotated but ship no py.typed, so mypy follows their imports anyway. The rest are small test fixes, regenerated into _sync. Prompt: yes [to rebasing roadmap-1.2 onto main, now with the PR #7 merge, and fixing the 24 mypy --strict errors it then has] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
pyproject.toml with hatch-vcs, Python 3.11+ and the dual licence with
license-files. Per D7 the author's template is the baseline (ruff,
pre-commit, lychee, Makefile, CONTRIBUTING.md), with towncrier fragments
in news/ and the test, changelog and release workflows taken from
calendaring-jmap. SECURITY.md points at private vulnerability reporting.
The sdist leaves out the prototypes and untracked tmp-* notes. A stub
package and one test give pytest and the build something to run.
Prompt: merge PR then start with 1.5 [merge https://github.com//pull/5, then start roadmap item 1.5]
Followup-Prompt: The github pypi environment can probably be created using
gh?Assisted-By: Claude Opus 5.5 noreply@anthropic.com
🤖 Generated with Claude Code