Repository navigation
Conversation
|
Thanks for the pull request, @Prajas02! A maintainer will review it shortly. |
Insufficient dataNot enough activity yet to make a reliable assessment. This is an automated analysis by AgentScan |
|
One or more PR-quality checks did not pass. Review the PR Quality Checks summary in the workflow run for the failed checks and their details, then make any necessary updates. Checklist items may remain unchecked while work is in progress. Please tick each item as you complete it. If you used AI assistance, follow the project's Responsible AI use policy and provide the required disclosures. |
|
Thank you for the contribution. Please follow our responsible AI usage and clarify how you used AI. The policy is linked below. PLease read it. |
AI assistance: Google Antigravity (Gemini 3.8 Flash) helped update the changelog entry and format the disclosure per policy.
|
Hi @angatha Thank you for pointing me to the Responsible AI use policy. I appreciate the project's standards on transparency and maintainer time, and I am glad to provide the complete disclosure and clarify how AI was used for this PR. 1. AI Tool & Model Disclosure
2. How AI Was Used (Prompts & Interactions Summary)
3. Responsibility & Validation
4. Updates Made to PR
Please let me know if you would also like me to reword or amend the git commit messages on the branch. |
Closes #2123
What this changes
REQUEST-STATUSwas written with escaped field separators (2.0\;Success), which is not valid RFC 5545 and is not readable by other clients. Parsing also split a field at an escaped\;.vRequestStatusalready stores its value in the escaped wire form (new()escapes each field and thedescription/dataaccessors unescape them), so the fix makes the reader and writer agree with that:vRequestStatus.to_ical()writes the value as is, without escaping the separators again.vRequestStatus.get_value_from_content_line()hands the raw, still escaped value to the type. This uses the hook the parser already offers for value types that must not be unescaped (asvUnknowndoes).2.0\;Success) are detected and unescaped once, so existing files are still read correctly.\n, so they cannot break the content line.Before / after
vRequestStatus.new("3.1", "Invalid property value", "DTSTART:96-Apr-01")3.1\;Invalid property value\;DTSTART:96-Apr-013.1;Invalid property value;DTSTART:96-Apr-012.0;Success\; with note;x\,ySuccess, datawith note;x,ySuccess; with note, datax,y2.0\;Success(2, 0),Success(2, 0),SuccessTests
14 of the new tests fail on main and pass with this change. The full test suite and ruff pass.
Checklist
news/