Repository navigation
Add return type hints to set_dtstamp_* helper functions - #2126
Open
AlexBritoOfficial wants to merge 1 commit into
Open
AlexBritoOfficial wants to merge 1 commit into
AlexBritoOfficial wants to merge 1 commit into
Conversation
AlexBritoOfficial
requested review from
niccokunzmann and
stevepiercy
as code owners
November 15, 2026 23:02
Contributor
|
Thanks for the pull request, @AlexBritoOfficial! A maintainer will review it shortly. |
Contributor
|
One or more PR-quality checks did not pass. Review the PR Quality Checks summary in the workflow run for the failed checks and their details, then make any necessary updates. Checklist items may remain unchecked while work is in progress. Please tick each item as you complete it. If you used AI assistance, follow the project's Responsible AI use policy and provide the required disclosures. |
None of the three helpers return a value, so hint them as -> None. Contributes to PyCalendar#938 AI use: Claude Sonnet 5 helped find the untyped helpers and verify the hints against their usage. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
AlexBritoOfficial
force-pushed
the
issue-938-set-dtstamp-helpers-type-hints
branch
from
November 15, 2026 23:12
8ad0f69 to
e1c4020
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Description
Added
-> Nonereturn type hints to the set_dtstamp_attribute, set_dtstamp_item, and set_dtstamp_add helper functions in test_component.py. None of them have a return statement.Checklist
Additional information
No behavior change; type-hint-only fix. No new tests or docs needed.