Skip to content

Add return type hints to set_dtstamp_* helper functions - #2126

Open
AlexBritoOfficial wants to merge 1 commit into
PyCalendar:mainfrom
AlexBritoOfficial:issue-938-set-dtstamp-helpers-type-hints
Open

AlexBritoOfficial wants to merge 1 commit into
PyCalendar:mainfrom
AlexBritoOfficial:issue-938-set-dtstamp-helpers-type-hints

Conversation

@AlexBritoOfficial

@AlexBritoOfficial AlexBritoOfficial commented Nov 15, 2026 •

Copy link
Copy Markdown

Linked issue

Description

Added -> None return type hints to the set_dtstamp_attribute, set_dtstamp_item, and set_dtstamp_add helper functions in test_component.py. None of them have a return statement.

Checklist

  • I added a change log entry, following the instructions in all subsections under Change log requirements.
  • I followed icalendar's Artificial intelligence policy and disclosed my Responsible AI use in my commit messages, if applicable.
  • I added or updated tests, if applicable.
  • I ran and ensured all tests pass locally by following Run tests.
  • I added or edited documentation as necessary, both as docstrings to be rendered in the API documentation and narrative documentation, following the Style guide.

Additional information

No behavior change; type-hint-only fix. No new tests or docs needed.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the pull request, @AlexBritoOfficial! A maintainer will review it shortly.

@github-actions github-actions Bot added the ai-suspicion This contribution is possibly created with lots of AI help without enough human understanding. label Nov 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

One or more PR-quality checks did not pass. Review the PR Quality Checks summary in the workflow run for the failed checks and their details, then make any necessary updates.

Checklist items may remain unchecked while work is in progress. Please tick each item as you complete it.

If you used AI assistance, follow the project's Responsible AI use policy and provide the required disclosures.

None of the three helpers return a value, so hint them as -> None.

Contributes to PyCalendar#938

AI use: Claude Sonnet 5 helped find the untyped helpers and verify
the hints against their usage.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@AlexBritoOfficial
AlexBritoOfficial force-pushed the issue-938-set-dtstamp-helpers-type-hints branch from 8ad0f69 to e1c4020 Compare November 15, 2026 23:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-suspicion This contribution is possibly created with lots of AI help without enough human understanding.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant