Repository navigation
Correct return type hint on rrule fixture - #2131
Open
AlexBritoOfficial wants to merge 3 commits into
Open
AlexBritoOfficial wants to merge 3 commits into
AlexBritoOfficial wants to merge 3 commits into
Conversation
rdate returns a date, datetime, or tuple of two datetimes from its parametrized lambdas, so hint it as -> date | datetime | tuple[datetime, datetime]. Contributes to PyCalendar#938 AI use: Claude Sonnet 5 helped find the untyped fixture and verify the hint against its usage. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
component returns an Event or Todo instance, matching the file's existing ET alias, so hint it as -> ET. Contributes to PyCalendar#938 AI use: Claude Sonnet 5 helped find the untyped fixture and verify the hint against its usage. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
rrule was hinted as -> str, but its params (RRULE_0 through RRULE_4) are vRecur instances, so correct it to -> vRecur. Contributes to PyCalendar#938 AI use: Claude Sonnet 5 helped find the incorrect hint and verify the fix against its usage. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
AlexBritoOfficial
requested review from
niccokunzmann and
stevepiercy
as code owners
November 16, 2026 02:06
Contributor
|
Thanks for the pull request, @AlexBritoOfficial! A maintainer will review it shortly. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Description
Corrected the return type hint on the rrule fixture in test_rrule.py from
strtovRecur. Its parametrized values, RRULE_0 through RRULE_4, are all vRecur.from_ical(...) results, not strings, so the previous hint was simply wrong.Checklist
Additional information
No behavior change; this fixes an incorrect existing type hint rather than adding a missing one.