Repository navigation
feat(recur): add bymonthday property accessor to vRecur (#1851) - #2175
Open
RishabhIIITD wants to merge 1 commit into
Open
RishabhIIITD wants to merge 1 commit into
RishabhIIITD wants to merge 1 commit into
Conversation
RishabhIIITD
requested review from
angatha,
niccokunzmann and
stevepiercy
as code owners
November 20, 2026 03:07
Contributor
|
Thanks for the pull request, @RishabhIIITD! A maintainer will review it shortly. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
bymonthdayproperty accessor (getter, setter, and deleter) toicalendar.prop.vRecurin accordance with RFC 5545 Section 3.3.10.Changes
Getter (
vRecur.bymonthday):tuple[int, ...]containing the days of the month.()ifBYMONTHDAYis absent or empty.[-31, -1]or[1, 31]withInvalidCalendar.InvalidCalendar.Setter (
vRecur.bymonthday = value):None(deletes the property).[-31, -1]or[1, 31](zero is forbidden).NonedeletesBYMONTHDAY.bool,str, arbitrary objects) withTypeError.vInt.Deleter (
del recur.bymonthday):BYMONTHDAYif present.Tests & News:
src/icalendar/tests/prop/recur/test_bymonthday.py(27 test cases covering valid ranges, negatives, bounds, deletion, type/value error handling, and round-tripping).news/1851.feature.9.