Repository navigation
fix: read CATEGORIES spread over several lines - #72
Merged
Merged
Conversation
RFC 5545 allows CATEGORIES more than once, and icalendar then returns a list; list-categories and timewarrior tracking crashed on it. Both now use comp.categories (icalendar>=6.2.0), skipping empty values. That accessor inserts an empty CATEGORIES when there is none (PyCalendar/icalendar#1722), so the interactive category prompt may store a blank line until caldav also cleans on save (python-caldav/caldav#774). Fixes #71 Prompt: I think #71 should just be fixed. (...) Followup-Prompt: I think maybe we're going a bit over the board (sic) here. 1) the correct fix is to use `icalendar_component.categories` all over the place. I'm reluctant to make workarounds everywhere for a bug that will be fixed at some point - and an empty CATEGORY-line is not that bad, as long as we can avoid crashing on it. 2) we have a workaround in place in caldav removing blank CATEGORIES-lines now when loading data from the server, and soon enough it will do the same on writes. I think that's all that is needed. Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message: