BioShake Documentation - #752
Merged
Merged
Conversation
A new backend for the BioShake, as well as adding the class to the __init__.py file
1.) Add reset and home in setup 2.) Add acceleration/deceleration to shaking function 3.) Asserted speed, temperature, and acceleration based on model 4.) More error handling in general
Fix parameter of shake and stop_shaking functions
Documentation for the BioShake backend
Member
|
looks good! two small comments:
for bs in [bs1, bs2, bs3, bs4]:
await bs.setup(skip_home=False)
await bs.shake(speed=500)could be async def setup_and_shake(bs):
await bs.setup(skip_home=False)
await bs.shake(speed=500)
await asyncio.gather(
setup_and_shake(bs1),
setup_and_shake(bs2),
setup_and_shake(bs3),
setup_and_shake(bs4),
)if you wanted to run them in parallel |
Contributor
Author
|
Member
|
thanks! will be live in 40 min or so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the wiki documentation for using the BioShake backend. First time doing this, so please let me know what needs to be changed.