ssl backend for thermo / applied biosystems ATC automated thermal cycler - #762
Merged
Conversation
ben-ray
commented
Nov 22, 2025
| if self.bid != "31": | ||
| raise NotImplementedError("Lid control is only available for BID 31 (ATC)") | ||
| res = await self.send_command({"cmd": "lidclose"}, response_timeout=20, read_once=False) | ||
| res = await self.send_command({"cmd": "lidclose"}, response_timeout=20, read_once=True) |
Contributor
Author
There was a problem hiding this comment.
At least when using SSL, this command will timeout if I use read_once = False, but with read_once = True, the command completes when the instrument is physically finished with the movement
Member
ben-ray
commented
Nov 22, 2025
| if self.bid != "31": | ||
| raise NotImplementedError("Lid control is only available for BID 31 (ATC)") | ||
| res = await self.send_command({"cmd": "lidopen"}, response_timeout=20, read_once=False) | ||
| res = await self.send_command({"cmd": "lidopen"}, response_timeout=25, read_once=True) |
Contributor
Author
There was a problem hiding this comment.
it takes more than 20 seconds to open lid (~22 for me), hence increasing timeout to 25
Contributor
|
my pr for the same function was submitted minutes ago lol |
ben-ray
commented
Nov 22, 2025
|
|
||
| if hostname is not None: # ssl connect | ||
| self.is_ssl = True | ||
| self.device_shared_secret = b"53rv1c3" + hostname.encode("ascii") |
Contributor
Author
There was a problem hiding this comment.
the instrument uses a different shared secret for ssl compared to non-ssl, so I remove the shared-secret option from the backend so the connection always uses the correct shared secret for ssl vs non-ssl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My 384 ATC never was able to connect by IP alone in the .exe software, but could connect by SSL. This adds SSL connection as an option to PLR by inputting a hostname into thermal cycler setup, like so: