Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip a possible -git suffix from emcc version #2470

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Feb 5, 2025

Compare here:
https://github.com/python/cpython/blob/main/configure.ac#L810
which just uses cut -f1 -d- to delete everything after the -. But we're only after deleting -git.

@messense messense merged commit 031de01 into PyO3:main Feb 5, 2025
36 of 38 checks passed
@hoodmane hoodmane deleted the emcc-version-strip-git branch February 5, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants