fix: skip legacy manylinux aliases not in PyPI allow-list#3078
Merged
fix: skip legacy manylinux aliases not in PyPI allow-list#3078
Conversation
`manylinux_2_17` has `manylinux2014` as a legacy alias, but PyPI static allow-list never included `manylinux2014_riscv64`. This caused wheels built with `--manylinux 2_17` for riscv64 to fail PyPI validation. Only add legacy alias tags when the full tag (alias + arch) exists in PyPI `ALLOWED_PLATFORMS` list.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts platform tag generation to avoid emitting legacy manylinux alias tags that PyPI will reject (e.g., manylinux2014_riscv64), fixing validation failures for --manylinux 2_17 on riscv64.
Changes:
- Import PyPI’s static
ALLOWED_PLATFORMSallow-list. - Gate legacy alias tag emission on presence in
ALLOWED_PLATFORMS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
manylinux_2_17hasmanylinux2014as a legacy alias, but PyPI static allow-list never includedmanylinux2014_riscv64. This caused wheels built with--manylinux 2_17for riscv64 to fail PyPI validation.Only add legacy alias tags when the full tag (alias + arch) exists in PyPI
ALLOWED_PLATFORMSlist.