Conversation
…t` symbol When using zig as the linker for windows-gnu targets, the `PyInit_<module>` symbol is not exported, causing Python to fail to import the module. This generates a `.def` file in `target/maturin/` that explicitly exports the symbol, passed to the linker via `-C link-arg`. Also refactors `target/maturin` directory creation into a shared `ensure_target_maturin_dir()` helper used by compile and repair. Fixes PyO3#922
messense
force-pushed
the
fix/zig-windows-gnu-pyinit-export
branch
from
1143c9b to
58ef24f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using zig as the linker for windows-gnu targets, the
PyInit_<module>symbol is not exported, causing Python to fail to import the module.This generates a
.deffile intarget/maturin/that explicitly exports the symbol, passed to the linker via-C link-arg.Also refactors
target/maturindirectory creation into a sharedensure_target_maturin_dir()helper used by compile and repair.Fixes #922