You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Most of the changes in this PR are a search-and-replace from std:: to core::. The only other change I've made is in the datetime file. It used the Once type from std. I've updated it to use AtomicBool instead.
This is the first PR from this converstaion: #5856 (comment)
use a feature-flag to conditionally use a separate crate that can sleep in no_std
The first way is technically a breaking change if anyone is using the PyGILState_Ensure method from the ffi crate as they would have to deal with pinned stack objects some other way, but I think it's simpler, so I will go with that one unless you object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added
no_stdto thepython-fficrate.Most of the changes in this PR are a search-and-replace from
std::tocore::. The only other change I've made is in the datetime file. It used theOncetype fromstd. I've updated it to useAtomicBoolinstead.This is the first PR from this converstaion: #5856 (comment)