Skip to content

ci: switch to Cargo build.warnings #6212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jinmay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: switch to Cargo build.warnings #6212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,5 +135,8 @@ jobs:
env:
CARGO_TERM_VERBOSE: ${{ inputs.verbose }}
RUST_BACKTRACE: 1
RUSTFLAGS: "-D warnings"
# `build.warnings` avoids the cache-busting from `RUSTFLAGS`; respected on
# Cargo 1.97+ only (MSRV jobs fall back to warn). rustdoc isn't covered by
# it, so RUSTDOCFLAGS stays.
Comment on lines +138 to +140

@WaterWhisperer WaterWhisperer Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the comments here are somewhat redundant or verbose

CARGO_BUILD_WARNINGS: deny
RUSTDOCFLAGS: "-D warnings"
6 changes: 3 additions & 3 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1665,10 +1665,10 @@ def check_feature_powerset(session: nox.Session):
*abi3t_version_features,
]

# deny warnings
# deny warnings; `build.warnings` avoids the cache-busting from `RUSTFLAGS`
# and is respected on Cargo 1.97+ only (MSRV falls back to warn).
Comment on lines +1668 to +1669

@WaterWhisperer WaterWhisperer Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

env = os.environ.copy()
rust_flags = env.get("RUSTFLAGS", "")
env["RUSTFLAGS"] = f"{rust_flags} -Dwarnings"
env["CARGO_BUILD_WARNINGS"] = "deny"

subcommand = "hack"
if "minimal-versions" in session.posargs:
Expand Down
Loading