Skip to content

feat: add river-water and sea-water sourced heat pumps #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 56 commits into
base: master
Choose a base branch
from

Conversation

amos-schledorn
Copy link
Contributor

@amos-schledorn amos-schledorn commented Mar 28, 2025

Closes # (if applicable).

Changes proposed in this Pull Request

This PR adds potential river-water and sea-water sourced heat pumps based on the implementations by @MajaHIC, @juboerms and @felix-land:

  • retrieval of HERA data for river discharge and ambient temperature
  • retrieval of Copernicus data for seawater temperatures
  • Computation of river-water heat potentials per onshore region (approximation of river water temperature from ambient temperature based on Triebs & Tsatsaronis 2022
  • Mapping of seawater temperatures to onshore regions
  • For both river water and sea water, DEA's excess-heat-sourced heat pumps are assumed for cost data - improvement to be tracked in separate issue

Open TODOs

  • Introduce lower temperature threshold for sea water utilisation
  • Add Copernicus data to bundle
  • Add copyright notice for Copernicus data
  • Update data retrieval
  • Add plotting procedure for heat potentials
  • Final sanity checks

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@amos-schledorn amos-schledorn marked this pull request as draft March 28, 2025 17:47
pre-commit-ci bot and others added 27 commits March 28, 2025 17:47
…ure dataset with source and licensing information
amos-schledorn and others added 27 commits April 4, 2025 15:43
…o bundle retrieval and remove unused retrieval script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant