-
Notifications
You must be signed in to change notification settings - Fork 280
Non-sequestered HVC Waste Allocation According to Population #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR separates the handling of HVC waste from process emissions and distributes non-sequestered HVC waste based on population, improving code clarity and logical emissions allocation. Key changes include:
- Separating HVC waste processing from process emissions and introducing distinct calculations for non-sequestered HVC.
- Adding a store for population-distributed non-sequestered HVC and updating links to reflect the new distribution logic.
- Updating plotting configuration with a new color for non-sequestered HVC.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
scripts/prepare_sector_network.py | Separates HVC waste handling, adds store/link for population-based distribution, and updates efficiency parameters. |
config/plotting.default.yaml | Adds a color code for non-sequestered HVC to support visual differentiation. |
Files not reviewed (1)
- doc/release_notes.rst: Language not supported
Comments suppressed due to low confidence (2)
scripts/prepare_sector_network.py:4649
- Replacing 'efficiency2' with 'efficiency' changes the parameter passed to the link; please confirm that this update is intentional and that it captures the intended scaling for CO2 intensity without omitting adjustments from non-sequestered or process emissions.
efficiency=costs.at["oil", "CO2 intensity"]
scripts/prepare_sector_network.py:4615
- [nitpick] Appending the suffix directly to the index may lead to duplicated labels if the index already contains ' non-sequestered HVC'; consider verifying that the index values are consistently unique.
HVC_potential.index = HVC_potential.index + " non-sequestered HVC"
Great, PR! I would suggest to go two steps further: Step 1 (could be done in this PR): Decouple non-sequestered HVC completely from the oil_demand and instead of using the Step 2 (separate PR): Decouple the waste sector from the industry sector. With the decoupling of process emissions from naptha for industry, that should be relatively straightforward. General remark: We might have to be a bit careful with potential double counting in "municipal solid waste" and "non-sequestered HVC" |
@lindnemi I moved the the locations of non-sequestered HVC to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The location of the non-sequestered HVC is now much cleaner and follows the style of the other oil carriers more closely.
However, what I suggested, was to decouple the HVC waste entirely from the oil_sector, i.e., to always use full spatial resolution of HVC waste by assigning them to all nodes
, regardless if options['regional_oil_demand']
is True or False.
Since there is going to be a second PR for decoupling the waste sector from the overall industry sector, I leave it up to you if you want to implement the decoupling from regional_oil_demand
already here or in the follow up PR.
Otherwise the PR looks good (Caveat: I only looked at the code, but didn't run it, let me know if you need a second person to run it, i will have time tomorrow)
a2e3ed2
to
fbc523a
Compare
Changes proposed in this Pull Request
This PR entangles the
naphtha for industry
links.So far, these links included the production of HVC (and therefore meeting the load
naphtha for industry
) that is linked to process emissions as well as the waste handling of HVC at its end of life.In this PR those two processes are separated to make the code easier to comprehend and distribute the emissions from HVC waste in a more logical sense:
Test
workflow runs locally with the different config settings
waste_to_energy: true/false
waste_to_energy_cc: true/false
regional_oil_demand: true/false
Results
waste_to_energy: false
andwaste_to_energy_cc: false
: 60.43 Mtnaphtha for industry
load: 71.18 Mtnaphtha for industry
linksStore energy content
Checklist
envs/environment.yaml
.not applicable
config/config.default.yaml
.not applicable
doc/configtables/*.csv
.not applicable
doc/data_sources.rst
.not applicable
doc/release_notes.rst
is added.