Skip to content

Conversation

@virio-andreyana
Copy link
Collaborator

Closes #622 and continues from #264

Changes proposed in this Pull Request

This is a re-attempt to restructure config files by categorizing sector and adding wildcard options specifying if its enable or not.

The first stage is to integrate the options wildcard in config (see config.default.yaml). It tries to have backward compatibility but fails partially due to the addition of co2 as a section in config.

The second stage is to integrate the sector options wildcard in config (see config.new.yaml). This was the propose design from me and @FabianHofmann. We are looking forward for more suggestion!

Problems/Challanges that might arise

  • backward compatibility
  • esoteric wildcard options
  • adding more params

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@virio-andreyana
Copy link
Collaborator Author

This draft request is closed down so that its split into

  • Add wildcards option in config (full backward compatibility)
  • Restructure config files (not backward compatible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restructure config file

2 participants