-
Notifications
You must be signed in to change notification settings - Fork 46
updated add_biochar_pyrolysis (closes #171) #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you highlight the unit changes in the release notes as a breaking change? I think it's ok as the feature is quite new, but generally we want to avoid units changing back and forth between versions.
Also please merge the upstream master and run compile_cost_assumptions once again. Thx!
removed print flag for publications
Great, now it's just about resolving the merge conflicts and documenting the unit change in the release notes @BertoGBG! |
Closes #171
Changes proposed in this Pull Request
update functions biochar pyrolysis. fixed error in investment cost and converted all units to tCO2e sequestered
Checklist
doc
.doc/release_notes.rst
of the upcoming release is included.