-
Notifications
You must be signed in to change notification settings - Fork 46
fix: Remove geothermal-sourced HPs and update geothermal-sourced heat source #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…mal heat source and assume 2000m depth
…at pumps and adjust costs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 17 changed files in this pull request and generated no comments.
Files not reviewed (15)
- docs/release_notes.rst: Language not supported
- outputs/US/costs_2020.csv: Language not supported
- outputs/US/costs_2025.csv: Language not supported
- outputs/US/costs_2030.csv: Language not supported
- outputs/US/costs_2035.csv: Language not supported
- outputs/US/costs_2040.csv: Language not supported
- outputs/US/costs_2045.csv: Language not supported
- outputs/US/costs_2050.csv: Language not supported
- outputs/costs_2020.csv: Language not supported
- outputs/costs_2025.csv: Language not supported
- outputs/costs_2030.csv: Language not supported
- outputs/costs_2035.csv: Language not supported
- outputs/costs_2040.csv: Language not supported
- outputs/costs_2045.csv: Language not supported
- outputs/costs_2050.csv: Language not supported
Comments suppressed due to low confidence (2)
test/test_compile_cost_assumptions.py:118
- Ensure that the removal of 'central geothermal-sourced heat pump' from the test mappings does not leave any gaps in test coverage for related functionality.
"central geothermal-sourced heat pump": "inputs/technology_data_for_el_and_dh.xlsx",
scripts/compile_cost_assumptions.py:928
- Confirm that the new cost conversion formula for the geothermal heat source is adequately covered by unit tests, especially for edge cases involving the input dimensions.
elif tech_name == "central geothermal heat source":
I'm not really sure where the changes to US data are coming from. Any idea @fneum? |
US changes seem to be linked to this commit: 756f989 Looks like the outputs had not been properly regenerated before the PR was merged. fyi @danielelerede-oet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for the minor spelling mistake and the failing CI.
This is bad but works around test
for more information, see https://pre-commit.ci
Changes proposed in this Pull Request
That's contradicting e.g. Pieper et al. who find the costs for the heat pump only to be the same for most heat sources.
So, I would suggest using excess-heat sourced heat pumps for the heat pump part of geothermal heating and the proposed cost calculation for the heat source.
Checklist
doc
.environment.yaml
(if applicable).doc/release_notes.rst
of the upcoming release is included.