Skip to content

Industrial CCS retrofits data #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

danielelerede-oet
Copy link
Contributor

@danielelerede-oet danielelerede-oet commented Apr 16, 2025

Changes proposed in this Pull Request

This PR adds data to model:

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

@danielelerede-oet danielelerede-oet marked this pull request as ready for review April 16, 2025 17:32
@euronion euronion self-requested a review May 12, 2025 15:30
Copy link
Collaborator

@euronion euronion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More data, nice! :)

Some comments. Can you also merge the current master so we can check whether there are no unintended overlaps? Thanks!

iron-air battery discharge,efficiency,2035,0.62,per unit,2023,"Form Energy, docu/FormEnergy_Europe_modeling_recommendations_2023.03.pdf, p4",
iron-air battery discharge,efficiency,2040,0.63,per unit,2023,"Form Energy, docu/FormEnergy_Europe_modeling_recommendations_2023.03.pdf, p4",
iron-air battery,lifetime,2030,17.5,years,2023,"Form Energy, docu/FormEnergy_Europe_modeling_recommendations_2023.03.pdf, p4",
ethanol capture retrofit,FOM,2030,7,%/year,2019,"National Petroleum Council, Meeting the Dual Challenge - A Roadmap to At-Scale Deployment of Carbon Capture, Use, and Storage: https://dualchallenge.npc.org/files/CCUS-Chap_2-030521.pdf, accessed 2024-16-04",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can you check the "accessed" date? Should that be 2025? The date format is also bad, please use YYYY-MM-DD .
  • Can you add the page or table number from where you got the information?
  • Can we make the naming more clear, i.e. this is ethanol carbon capture retrofit, right, i.e. for retrofitting carbon capture to an ethanol plant? (applies to all other new entries as well)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @euronion, thanks for noticing the issue about date! My bad!
Concerning more details on the origin of data and naming I also made the requested changes!

@euronion euronion self-requested a review May 14, 2025 14:56
Copy link
Collaborator

@euronion euronion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Spot checked, LGTM!

@euronion euronion merged commit 4e48474 into PyPSA:master May 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants