-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to set precision
in CWT, increase default to 12
#570
base: main
Are you sure you want to change the base?
Conversation
precision
, increase default to 12precision
in CWT, increase default to 12
Higher `precision` doesn't help with lower scales
Thanks, I am fine with exposing this parameter. I will take a look at the info you found soon and review it a little closer. |
@grlee77 Some interesting findings here (see bottom); to my surprise, I'm curious on rationale behind integrated wavelet, which isn't documented on the site you found; perhaps it can be improved further. |
… implement the precision option
hi @grlee77 is that PR still planned ? |
Addresses this Issue. Detailed explanation here; a summary:
precision
distorts CWT, and heavily at high scales.64
are increasingly distorted.precision=10
is low, andprecision=12
does not add much computation cost, while considerably remedying 1-3.At the least, the user should get to decide
precision
instead of carving it in stone. And a doc/comment should be made about these caveats.Improvement comparison
Code