Security: add explicit runtime warning for PickleSerializer#3809
Open
RinZ27 wants to merge 1 commit intoPylons:mainfrom
Open
Security: add explicit runtime warning for PickleSerializer#3809RinZ27 wants to merge 1 commit intoPylons:mainfrom
RinZ27 wants to merge 1 commit intoPylons:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit runtime warnings in
PickleSerializer.loadsnow highlight the inherent security risks of the pickle protocol. While version 2.0 already deprecated this class in favor ofJSONSerializer, providing a visible warning during execution ensures that developers maintain awareness of potential RCE vulnerabilities in legacy session configurations. During my analysis of the session logic, it became clear that a silent deprecation might not be enough for production environments still relying on old serialized data.Documentation for this change has been added to
CHANGES.rstunder the "Backward Incompatibilities" section. This ensures that users upgrading to the latest version are fully informed of the new warning behavior. Verification was performed to ensure the warning triggers correctly during deserialization without disrupting the application flow, which I believe provides a safer path toward total removal of the serializer in future major releases.